Open
Conversation
wbolster
requested review from
a user and
wbolster
and removed request for
wbolster
wbolster
requested changes
Oct 29, 2018
Collaborator
There was a problem hiding this comment.
🌳
hey, thanks for your contribution!
a few remarks:
-
i do think the api is confusing, since working of a path object, file pointer, or (byte) string are conceptually different things, yet they're all packed into the same api. this makes it easy to write confusing or broken code.
-
the media type is optional according to rfc2397, yet the proposed implementation requires it
-
tests are missing
-
there are a few unrelated changes that have nothing to do with adding support for building
data:uris
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1